ci: add check to enforce presence of license identifier #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Github action doesn't work out of the box but I submitted enarx/spdx#24 and enarx/spdx#25 that should make it work. |
ingomueller-net
changed the title
ingomueller-net
force-pushed
the
gh-action-license
branch
from
a72539a to
d3a9898
Compare
jpienaar
approved these changes
Oct 28, 2024
|
Yeah, exactly. |
ingomueller-net
force-pushed
the
gh-action-license
branch
from
d3a9898 to
16c38b2
Compare
|
I see it worked and flagged some :) |
ingomueller-net
force-pushed
the
gh-action-license
branch
from
16c38b2 to
9d9b19b
Compare
Signed-off-by: Ingo Müller <[email protected]>
Signed-off-by: Ingo Müller <[email protected]>
Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
gh-action-license
branch
from
9d9b19b to
a6c8e65
Compare
That file doesn't seem to be particularly important to specify the license for but our CI check complains about it and I guess it cannot harm either. Signed-off-by: Ingo Müller <[email protected]>
This is necessary because the action expects the license identifier to be a space-separated list of strings via its main parameter mechanism, which breaks with our license identifier, which contains strings. Fortunately, there is a fallback mechanism via environment variables that allows to specify the list of identifiers as a JSON array. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
gh-action-license
branch
from
f9327c3 to
296c226
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.