Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: op-proposer logic #104

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: op-proposer logic #104

merged 1 commit into from
Sep 4, 2024

Conversation

ratankaliani
Copy link
Member

Small fixes to the op-proposer logic:

  1. When an agg proof failed, we incorrectly retried a span proof with the same bounds, which caused issues. We had not run into this issue before because AGG proofs typically didn't fail. The Modal proof server was not up, which is why the AGG proofs failed.
  2. In the start of the ProcessPendingProofs loop, we should only retry failed proofs IF they did not reach the prover network. Otherwise, we will constantly retry failed proofs from the prover network, which causes issues.

@ratankaliani ratankaliani merged commit ac60461 into ratan/docs Sep 4, 2024
1 check passed
ratankaliani added a commit that referenced this pull request Sep 5, 2024
* add

* docs

* docs

* docs

* add

* feat: add docker startup logic (#103)

* add docker startup logic

* add

* fix: delete the span batch server

* fix

* spin up and spin down

* add

* add

* add

* fix: fetch proofs that failed on server correctly (#104)

* rm outdated env

* wip

* docs: update

* add docs

* docs
@ratankaliani ratankaliani deleted the ratan/debug-proposer branch September 24, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant