Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): Add modifiers, owner #230

Merged
merged 9 commits into from
Nov 26, 2024
Merged

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Nov 26, 2024

  • Add back the owner parameter, which will simplify upgrades and make management of the contract straightforward. Rather than needing to re-initialize the contract, just use the onlyOwner modifier to update the verification key. The owner can be the governance smart contract or a multi-sig. Effectively reverts fix(contracts + proposer): checkpoint block hash #184
  • Modify verifierGateway -> verifier and use ISP1Verifier, rather than ISP1VerifierGateway, as the verifierGateway terminology is confusing and unnecessary for this context.
  • Add all initialization parameters to initParams.

Copy link

github-actions bot commented Nov 26, 2024

Metric Value
Batch Start 20,172,330
Batch End 20,172,335
Witness Generation (seconds) 9
Execution Duration (seconds) 9
Total Instruction Count 322,449,602
Oracle Verify Cycles 45,028,293
Derivation Cycles 235,622,936
Block Execution Cycles 29,835,970
Blob Verification Cycles 729
Total SP1 Gas 433,864,105
Number of Blocks 6
Number of Transactions 16
Ethereum Gas Used 1,125,700
Cycles per Block 53,741,600
Cycles per Transaction 20,153,100
Transactions per Block 2
Gas Used per Block 187,616
Gas Used per Transaction 70,356
BN Pair Cycles 0
BN Add Cycles 0
BN Mul Cycles 0
KZG Eval Cycles 0
EC Recover Cycles 436,485

@ratankaliani ratankaliani merged commit ef9f4bb into main Nov 26, 2024
10 checks passed
@ratankaliani ratankaliani deleted the ratan/add-modifier branch November 26, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants