Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add SKIP_L1_PROPOSAL flag to skip L1 transactions #291

Closed
wants to merge 1 commit into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Dec 17, 2024

Description

Added functionality to skip L1 transactions during testing by introducing a new environment variable SKIP_L1_PROPOSAL.

Changes

  • Added SKIP_L1_PROPOSAL environment variable (default: false)
  • When SKIP_L1_PROPOSAL=true, the script sets OP_SUCCINCT_SKIP_L1=true
  • Added logging to indicate when L1 transactions are being skipped

Usage

To skip L1 transactions during testing:
bash
SKIP_L1_PROPOSAL=true ./tools/ci/setup.sh

Testing

  • Tested with SKIP_L1_PROPOSAL=false (default behavior)
  • Tested with SKIP_L1_PROPOSAL=true
  • Verified that proofs are still generated and stored in database

Closes #258

   - Added SKIP_L1_PROPOSAL environment variable with default value false
   - When SKIP_L1_PROPOSAL=true, sets OP_SUCCINCT_SKIP_L1=true
   - Added logging when L1 transactions are skipped
   
   Closes succinctlabs#258
@crStiv
Copy link
Author

crStiv commented Dec 17, 2024

@ratankaliani hey may i know why did you rejected my pr? maybe ill try to redo it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add flag to skip L1 transaction
2 participants