Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to static call with custom call #23

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Add functionality to static call with custom call #23

merged 3 commits into from
Oct 21, 2024

Conversation

invocamanman
Copy link
Contributor

  • Let the user specify:
    • Custom calldata
    • Make deployments inside of a static call, being able to retrieve arbitrary information without deploying any contract

@yuwen01
Copy link
Collaborator

yuwen01 commented Oct 21, 2024

Refactored this PR to just refactor the existing ContractInput and new_evm functions to support contract creation as well.

yuwen01
yuwen01 approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@yuwen01 yuwen01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored the create and the call into a single method and did a couple other small fixes, after that lgtm

@yuwen01 yuwen01 merged commit 414ec3a into succinctlabs:main Oct 21, 2024
3 checks passed
@invocamanman
Copy link
Contributor Author

awesome ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuwen01 yuwen01 yuwen01 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@invocamanman @yuwen01