Skip to content

Commit

Permalink
chore: all feats, no feats, default feats top level workspace checks
Browse files Browse the repository at this point in the history
  • Loading branch information
nhtyy committed Nov 25, 2024
1 parent f9640e8 commit 64faf8b
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
20 changes: 20 additions & 0 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,26 @@ jobs:
env:
CARGO_INCREMENTAL: 1

- name: Check workspace no features
uses: actions-rs/cargo@v1
with:
command: check
args: --workspace --all-targets --no-default-features

- name: Check workspace with default features
uses: actions-rs/cargo@v1
with:
command: check
args: --workspace --all-targets

- name: Check workspace with all features
uses: actions-rs/cargo@v1
with:
command: check
args: --workspace --all-targets --all-features



examples:
name: Examples
runs-on:
Expand Down
2 changes: 1 addition & 1 deletion crates/core/executor/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ enum-map = { version = "2.7.3", features = ["serde"] }
test-artifacts = { workspace = true, optional = true }

[dev-dependencies]
sp1-zkvm = { workspace = true }
sp1-zkvm = { workspace = true, features = ["lib"] }

[features]
programs = ["dep:test-artifacts"]
Expand Down
4 changes: 4 additions & 0 deletions crates/verifier/src/tests.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#[cfg(feature = "std")]
use sp1_sdk::{install::try_install_circuit_artifacts, SP1ProofWithPublicValues};

#[test]
#[cfg(feature = "std")]
fn test_verify_groth16() {
// Location of the serialized SP1ProofWithPublicValues. See README.md for more information.
let proof_file = "test_binaries/fibonacci-groth16.bin";
Expand All @@ -19,6 +21,7 @@ fn test_verify_groth16() {
}

#[test]
#[cfg(feature = "std")]
fn test_verify_plonk() {
// Location of the serialized SP1ProofWithPublicValues. See README.md for more information.
let proof_file = "test_binaries/fibonacci-plonk.bin";
Expand All @@ -37,6 +40,7 @@ fn test_verify_plonk() {
}

#[test]
#[cfg(feature = "std")]
fn test_vkeys() {
let groth16_path = try_install_circuit_artifacts("groth16");
let s3_vkey_path = groth16_path.join("groth16_vk.bin");
Expand Down

0 comments on commit 64faf8b

Please sign in to comment.