-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cycle tracker test program #1276
Merged
ratankaliani
merged 9 commits into
ratan/add-cycle-tracker-report
from
ratan/cycle-tracking-program-execution
Aug 7, 2024
Merged
feat: cycle tracker test program #1276
ratankaliani
merged 9 commits into
ratan/add-cycle-tracker-report
from
ratan/cycle-tracking-program-execution
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ratan/cycle-tracking-program-execution
ratankaliani
changed the base branch from
dev
to
ratan/add-cycle-tracker-report
August 7, 2024 02:48
puma314
approved these changes
Aug 7, 2024
@@ -15,13 +15,13 @@ pub fn main() { | |||
let mut nums = vec![1, 1]; | |||
|
|||
// Setup a large vector with Fibonacci-esque numbers. | |||
println!("cycle-tracker-start: setup"); | |||
println!("cycle-tracker-report-start: setup"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we add this as another example? because i think we reference this in our docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
…into ratan/cycle-tracking-program-execution
…ng-program-execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another cycle tracking program as an example in the
cycle-tracking
folder to demonstratecycle-tracker-report
.While debugging CI on this PR, I found that we don't copy the ELF correctly when specifying the
binary
flag, merged in #1279 to resolve.