feat: integrate gpu into sdk #1301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
reviewed
Aug 12, 2024
sdk/src/provers/local.rs
Outdated
| return Err(anyhow::anyhow!( | ||
| "not enough memory to generate plonk proof. at least 128GB is required." | ||
| "not enough memory to generate plonk proof. at least 64GB is required." |
There was a problem hiding this comment.
made the threshold PLONK_MEMORY_GB_REQUIREMENT - 4, don't want to use 64gb exactly because lots of systems don't have 64GB exactly
sdk/src/provers/local.rs
Outdated
| @@ -3,6 +3,9 @@ use sp1_core::runtime::SP1Context; | |||
| use sp1_prover::{components::SP1ProverComponents, SP1Prover, SP1Stdin}; | |||
| use sysinfo::System; | |||
|
|
|||
| #[cfg(feature = "cuda")] | |||
| use sp1_cuda::SP1CudaProver; | |||
There was a problem hiding this comment.
nit: why don't you make a CudaProver instead of LocalProver and having the config flag stuff? that seems a bit cleaner
There was a problem hiding this comment.
agreed that's cleaner, done
There was a problem hiding this comment.
there is some repeated code but maybe its fine
There was a problem hiding this comment.
i think eventually we should make SP1CudaProver and SP1Prover conform to a single unifying trait
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.