feat: new precompile secp256r1 #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
It'd be great if you could add a PR description that specifies what your SP1 PR is doing.
Also, there's many places where there are outdated comments, and incorrect documentation (secp256r1 vs. secp256k1). Can you please meticulously go through and confirm that these are all correct. Especially given the scope of the PR, when there are small issues it makes it difficult to review.
kevjue
approved these changes
Oct 17, 2024
There was a problem hiding this comment.
It's looking really good! I'll approve, but please address a few related style and commenting related notes.
Also, please confirm with @tamirhemo about possibly merging the fields in the decompress table.
crates/core/machine/src/syscall/precompiles/weierstrass/weierstrass_decompress.rs
Outdated
Show resolved
Hide resolved
crates/core/machine/src/syscall/precompiles/weierstrass/weierstrass_decompress.rs
Outdated
Show resolved
Hide resolved
crates/core/machine/src/syscall/precompiles/weierstrass/weierstrass_decompress.rs
Outdated
Show resolved
Hide resolved
yuwen01
added a commit
that referenced
this pull request
Nov 8, 2024
Co-authored-by: John Guibas <[email protected]> Co-authored-by: Tamir Hemo <[email protected]> Co-authored-by: Bhargav Annem <[email protected]> Co-authored-by: Eugene Rabinovich <[email protected]> Co-authored-by: Shaked Regev <[email protected]> Co-authored-by: Yuwen Zhang <[email protected]> Co-authored-by: Matt Stam <[email protected]> Co-authored-by: shakedregev <[email protected]> Co-authored-by: Chris T. <[email protected]> Co-authored-by: mattstam <[email protected]> Co-authored-by: Kevin Jue <[email protected]> Co-authored-by: Conner Swann <[email protected]> Co-authored-by: Jonathan LEI <[email protected]> Co-authored-by: Tamir Hemo <[email protected]> Co-authored-by: rkm0959 <[email protected]> Co-authored-by: Ratan Kaliani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Includes precompile for secp256r1 along with a test in examples/patch-testing calling this precompile.
Details
With this new precompile, the p256 signature verification takes 55,581 cycles.