Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: doc devs need go, unneeded clone in prover loop #1688

Merged
merged 2 commits into from
Nov 16, 2024
Merged

chore: doc devs need go, unneeded clone in prover loop #1688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3002315
chore: devs need go, bad clone
nhtyy Oct 22, 2024
d2295bb
fix: rm lock diff
nhtyy Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This is a guide with helpful information for developers who want to contribute t

## Getting started

You can run the test suite in SP1 core by running the following command:
To build SP1, you must install [Go](https://go.dev/doc/install). You can run the test suite in SP1 core by running the following command:

```bash
cd core
Expand Down
2 changes: 1 addition & 1 deletion crates/core/machine/src/utils/prove.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ where
let mut reader = std::io::BufReader::new(file);
let state: ExecutionState =
bincode::deserialize_from(&mut reader).expect("failed to deserialize state");
let mut runtime = Executor::recover(program.clone(), state.clone(), opts);
let mut runtime = Executor::recover(program, state, opts);
runtime.maximal_shapes = shape_config
.map(|config| config.maximal_core_shapes().into_iter().map(|s| s.inner).collect());

Expand Down
Loading