Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primitives: add unit tests and small refactor #1751

Closed
wants to merge 2 commits into from
Closed

primitives: add unit tests and small refactor #1751

wants to merge 2 commits into from

Conversation

tcoratger
Copy link

This PR:

  • Provides unit tests for all methods in the primitive crate to secure implementations.
  • Provides some small refactorings at some places where speed or clarity can be improved.

@nhtyy
Copy link
Collaborator

nhtyy commented Dec 4, 2024

Thanks for the PR but closing this as its been awhile and most of the checks are failing. I would be supportive of these changes though.

@nhtyy nhtyy closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcoratger @nhtyy