Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add skip_deferred_proof_verification #1760

Merged
merged 4 commits into from
Nov 20, 2024
Merged

Conversation

ratankaliani
Copy link
Member

@ratankaliani ratankaliani commented Nov 6, 2024

Systems such as op-succinct require an additional flag to skip deferred proof verification when generating mock proofs, because their execution relies on the verification of compressed proofs (deferred proofs) which are invalid in mock mode.

@ratankaliani ratankaliani marked this pull request as ready for review November 7, 2024 21:01
@ratankaliani ratankaliani marked this pull request as draft November 7, 2024 21:02
Copy link

github-actions bot commented Nov 7, 2024

SP1 Performance Test Results

Branch: ratan/simulation-flags
Commit: de39dce
Author: ratankaliani

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 3.10 0.49 23s
ssz-withdrawals 2757356 17.27 128.89 35.43 1m18s
tendermint 12593597 6.76 270.45 98.31 2m10s

@ratankaliani ratankaliani changed the title feat: Add skip_deferred_proof_verification + refactor skip_simulation feat: Add skip_deferred_proof_verification + refactor skip_simulation GRO 105 Nov 19, 2024
@ratankaliani ratankaliani changed the title feat: Add skip_deferred_proof_verification + refactor skip_simulation GRO 105 feat: Add skip_deferred_proof_verification + refactor skip_simulation GRO-105 Nov 19, 2024
@ratankaliani ratankaliani marked this pull request as ready for review November 19, 2024 06:29
@ratankaliani ratankaliani changed the title feat: Add skip_deferred_proof_verification + refactor skip_simulation GRO-105 feat: Add skip_deferred_proof_verification + refactor skip_simulation Nov 19, 2024
@ratankaliani ratankaliani force-pushed the ratan/simulation-flags branch from c3d9854 to 3c71499 Compare November 19, 2024 22:01
@ratankaliani ratankaliani changed the title feat: Add skip_deferred_proof_verification + refactor skip_simulation feat: Add skip_deferred_proof_verification Nov 19, 2024
@ratankaliani ratankaliani force-pushed the ratan/simulation-flags branch from c0c2d7a to 07b7c68 Compare November 19, 2024 22:06
@ratankaliani ratankaliani merged commit 97ada66 into dev Nov 20, 2024
12 checks passed
@ratankaliani ratankaliani deleted the ratan/simulation-flags branch November 20, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants