-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add skip_deferred_proof_verification
#1760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP1 Performance Test Results Branch: ratan/simulation-flags
|
ratankaliani
changed the title
feat: Add
feat: Add Nov 19, 2024
skip_deferred_proof_verification
+ refactor skip_simulation
skip_deferred_proof_verification
+ refactor skip_simulation
GRO 105
ratankaliani
changed the title
feat: Add
feat: Add Nov 19, 2024
skip_deferred_proof_verification
+ refactor skip_simulation
GRO 105skip_deferred_proof_verification
+ refactor skip_simulation
GRO-105
ratankaliani
changed the title
feat: Add
feat: Add Nov 19, 2024
skip_deferred_proof_verification
+ refactor skip_simulation
GRO-105skip_deferred_proof_verification
+ refactor skip_simulation
ratankaliani
force-pushed
the
ratan/simulation-flags
branch
from
November 19, 2024 22:01
c3d9854
to
3c71499
Compare
ratankaliani
changed the title
feat: Add
feat: Add Nov 19, 2024
skip_deferred_proof_verification
+ refactor skip_simulation
skip_deferred_proof_verification
ratankaliani
force-pushed
the
ratan/simulation-flags
branch
from
November 19, 2024 22:06
c0c2d7a
to
07b7c68
Compare
yuwen01
reviewed
Nov 20, 2024
yuwen01
approved these changes
Nov 20, 2024
ratankaliani
added a commit
that referenced
this pull request
Nov 20, 2024
ratankaliani
added a commit
that referenced
this pull request
Nov 20, 2024
ratankaliani
added a commit
that referenced
this pull request
Nov 27, 2024
ratankaliani
added a commit
that referenced
this pull request
Dec 10, 2024
ratankaliani
added a commit
that referenced
this pull request
Dec 11, 2024
ratankaliani
added a commit
that referenced
this pull request
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Systems such as
op-succinct
require an additional flag to skip deferred proof verification when generating mock proofs, because their execution relies on the verification of compressed proofs (deferred proofs) which are invalid in mock mode.