Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docker on mac #1771

Merged
merged 7 commits into from
Nov 12, 2024
Merged

docs: docker on mac #1771

merged 7 commits into from
Nov 12, 2024

Conversation

yuwen01
Copy link
Contributor

@yuwen01 yuwen01 commented Nov 8, 2024

Clarifies that docker on mac might require higher memory via docker desktop.

Makes the error message more descriptive, and adds a release CI test to check docker mac proof generation.

EDIT: release ci test might be cooked https://stackoverflow.com/questions/77675906/github-actions-build-docker-image-on-arm64-macos-latest-xlarge

Copy link

github-actions bot commented Nov 8, 2024

SP1 Performance Test Results

Branch: yuwen/docker-doc-nit
Commit: e8fce68
Author: yuwen01

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.19 2.82 0.47 24s
ssz-withdrawals 2757356 17.37 127.82 35.01 1m19s
tendermint 12593597 6.77 269.57 100.02 2m8s

@yuwen01 yuwen01 merged commit 47eac33 into dev Nov 12, 2024
16 checks passed
@yuwen01 yuwen01 deleted the yuwen/docker-doc-nit branch November 12, 2024 22:51
@@ -31,7 +31,9 @@ which can be parallelized with multiple cores.
Our prover requires keeping large matrices (i.e., traces) in memory to generate the proofs. Certain steps of the prover
have a minimum memory requirement, meaning that if you have less than this amount of memory, the process will OOM.

This effect is most noticeable when using the Groth16 or PLONK provers.
This effect is most noticeable when using the Groth16 or PLONK provers. If you're running the Groth16 or Plonk provers locally

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuwen01 I did run into this issue today. The error message is very cryptic and I suggest making a note on the Quickstart page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants