-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: docker on mac #1771
Merged
Merged
docs: docker on mac #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SP1 Performance Test Results Branch: yuwen/docker-doc-nit
|
jtguibas
approved these changes
Nov 8, 2024
rsoeldner
reviewed
Dec 10, 2024
@@ -31,7 +31,9 @@ which can be parallelized with multiple cores. | |||
Our prover requires keeping large matrices (i.e., traces) in memory to generate the proofs. Certain steps of the prover | |||
have a minimum memory requirement, meaning that if you have less than this amount of memory, the process will OOM. | |||
|
|||
This effect is most noticeable when using the Groth16 or PLONK provers. | |||
This effect is most noticeable when using the Groth16 or PLONK provers. If you're running the Groth16 or Plonk provers locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuwen01 I did run into this issue today. The error message is very cryptic and I suggest making a note on the Quickstart page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifies that docker on mac might require higher memory via docker desktop.
Makes the error message more descriptive, and adds a release CI test to check docker mac proof generation.
EDIT: release ci test might be cooked https://stackoverflow.com/questions/77675906/github-actions-build-docker-image-on-arm64-macos-latest-xlarge