Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docker gnark ci test #1776

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

fix: docker gnark ci test #1776

wants to merge 13 commits into from

Conversation

yuwen01
Copy link
Contributor

@yuwen01 yuwen01 commented Nov 8, 2024 •
edited
Loading

Fixes a bug with the test ffi binding.

Moves all file writing to within docker to avoid permission issues.

Also renames and documents existing ci jobs related to docker for clarity.

@yuwen01 yuwen01 marked this pull request as draft November 8, 2024 04:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

SP1 Performance Test Results

Branch: yuwen/fix-docker-ci
Commit: 9a601f1
Author: yuwen01

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.18 2.78 0.46 24s ✅
ssz-withdrawals 2757356 17.32 127.65 35.04 1m19s ✅
tendermint 12593597 6.72 270.82 98.78 2m9s ✅

@yuwen01 yuwen01 marked this pull request as ready for review November 9, 2024 00:59
@nhtyy nhtyy added the ci Anything related to CI label Nov 21, 2024
@nhtyy nhtyy added the maybe-stale A pr or issue that hasnt seen alot of activity recently label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtguibas jtguibas jtguibas approved these changes

Assignees
No one assigned
Labels
ci Anything related to CI maybe-stale A pr or issue that hasnt seen alot of activity recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuwen01 @jtguibas @nhtyy