fix: runtime sharding #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
approved these changes
Feb 10, 2024
| // Every `shard_size` cycles, increment shard and reset clk within the shard. | ||
| if self.state.global_clk % self.shard_size == 0 && !self.unconstrained { | ||
| // If there's not enough cycles left for another instruction, move to the next shard. | ||
| if !self.unconstrained && max_syscall_cycles + self.state.clk >= self.shard_size * 4 { |
There was a problem hiding this comment.
can you leave a comment as to why the self.shard_size * 4 is the max_clk?
| @@ -75,7 +77,14 @@ pub fn debug_constraints<F: PrimeField, EF: ExtensionField<F>, A>( | |||
| builder.is_transition = F::zero(); | |||
| } | |||
|
|
|||
| air.eval(&mut builder); | |||
| let result = catch_unwind(AssertUnwindSafe(|| { | |||
There was a problem hiding this comment.
do you mean to keep this in?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also changes
debug_constraintsto print the offending row