chore: all feats, no feats, default feats top level workspace checks #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SP1 Performance Test Results Branch: n/features-workflow
|
nhtyy
force-pushed
the
n/features-workflow
branch
from
2144d18 to
87269dc
Compare
nhtyy
force-pushed
the
n/features-workflow
branch
from
87269dc to
f92a753
Compare
nhtyy
force-pushed
the
n/features-workflow
branch
from
890271d to
c714596
Compare
yuwen01
approved these changes
Nov 26, 2024
.github/workflows/pr.yml
Outdated
| @@ -186,7 +222,7 @@ jobs: | |||
|
|
|||
| cli: | |||
| name: CLI | |||
| runs-on: [runs-on, runner=8cpu-linux-x64, "run-id=${{ github.run_id }}"] | |||
| runs-on: [runs-on, runner=8cpu-linux-x64, disk=medium, "run-id=${{ github.run_id }}"] | |||
There was a problem hiding this comment.
just curious what happened here
There was a problem hiding this comment.
checkout the current failing CI, its out of space on CLI job, maybe we need large here too?
| @@ -44,7 +44,7 @@ enum-map = { version = "2.7.3", features = ["serde"] } | |||
| test-artifacts = { workspace = true, optional = true } | |||
There was a problem hiding this comment.
i ran into this issue too lol
|
yea just don't merge until ci passes |
nhtyy
force-pushed
the
n/features-workflow
branch
from
c5c777d to
112d625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.