Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workflow should force install just in case #1824

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: workflow should force install just in case #1824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62b7638
fix: workflow should overwrite
nhtyy Nov 26, 2024
268c0c4
fix: exsisting lint
nhtyy Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Run cargo check
Expand Down Expand Up @@ -85,7 +85,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Run cargo check
Expand Down Expand Up @@ -122,7 +122,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Run cargo fmt
Expand Down Expand Up @@ -165,7 +165,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Check workspace no features
Expand Down Expand Up @@ -209,7 +209,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Run cargo fmt
Expand Down Expand Up @@ -243,7 +243,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Run cargo prove new
Expand Down Expand Up @@ -277,7 +277,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Run Evaluation
Expand Down Expand Up @@ -324,7 +324,7 @@ jobs:
run: |
cargo run -p sp1-cli -- prove install-toolchain
cd crates/cli
cargo install --locked --path .
cargo install --force --locked --path .
cargo clean

- name: Run tendermint script
Expand Down Expand Up @@ -369,7 +369,7 @@ jobs:

# - name: "Install cargo-prove"
# run: |
# cargo install --locked --path ./crates/cli
# cargo install --force --locked --path ./crates/cli

# - name: "Install SP1 toolchain"
# run: |
Expand Down
4 changes: 2 additions & 2 deletions crates/prover/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,8 +1540,8 @@ pub mod tests {
setup_logger();
let prover = SP1Prover::<DefaultProverComponents>::new();
let program = test_artifacts::FIBONACCI_ELF;
let (pk, vk) = prover.setup(&program);
let pk2 = prover.setup(&program).0;
let (pk, _) = prover.setup(program);
let pk2 = prover.setup(program).0;
assert_eq!(pk.pk.commit, pk2.pk.commit);
}
}
Loading