feat(sdk): add support program registration #1842
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
SP1 Performance Test Results Branch: mattstam/sdk-network-v2-mergable
|
mattstam
changed the title
unrelated CI failing |
|
|
||
| /// Sets the fulfillment strategy for the client. By default, the strategy is set to `Hosted`. | ||
| pub fn with_strategy(&mut self, strategy: FulfillmentStrategy) { | ||
| self.strategy = strategy; | ||
| } |
There was a problem hiding this comment.
note: I will do other SDK improvements in a subsequent PR
| @@ -95,6 +97,76 @@ impl NetworkClient { | |||
| Ok(res.into_inner().nonce) | |||
| } | |||
|
|
|||
| /// Get the verifying key hash from a verifying key. The verifying key hash is used to identify | |||
| /// a program. | |||
| pub fn get_vk_hash(vk: &SP1VerifyingKey) -> Result<Vec<u8>> { | |||
There was a problem hiding this comment.
Wondering if we should use SP1VerifyingKeyHash([u32; 8]) or something
There was a problem hiding this comment.
will keep this in mind
Problem: uploading the elf and doing prover.setup(elf) to get the vk on every request is unnecessary.
Solution: the elf and vk are no longer sent every request, instead they are only sent if the program hasn't been registered in the network yet.
Previous SDK prove:
New SDK prove:
a. if error:
i. upload the elf
ii. call CreateProgram(vk_hash, vk, program_uri)
Example output with registration, since the program doesn't exist yet:
and then re-running it, it skips the registration: