Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): enhance dev mode warning with opt-level detection #1859

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link

Enhanced Dev Mode Warning with Opt-Level Detection

This PR enhances the warning message for local provers running in dev mode by:

  1. Making the warning message more visible with emojis and clear formatting
  2. Providing explicit instructions for improving performance
  3. Using opt-level detection instead of debug assertions to determine when to show the warning

Changes

  • Added opt-level detection in build script
  • Set environment variable when optimization level is low (0 or 1)
  • Updated warning message to be more visible and informative
  • Replaced debug_assertions check with opt-level detection

Testing

  • Verified formatting with cargo fmt --all -- --check
  • Note: Full verification with clippy is pending due to environment setup (missing m4 dependency)

Link to Devin run: https://app.devin.ai/sessions/dcaf1f3113fd4978b5d278d17de6ccd2

- Add opt-level detection in build script
- Set environment variable when optimization level is low
- Update warning message to be more visible with clear instructions
- Replace debug_assertions check with opt-level detection

Co-Authored-By: [email protected] <[email protected]>
Copy link
Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

Copy link

github-actions bot commented Dec 12, 2024

SP1 Performance Test Results

Branch: devin/1733968047-enhance-dev-mode-warning
Commit: c2a8850
Author: devin-ai-integration[bot]

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.17 2.74 0.46 25s
ssz-withdrawals 2757356 17.03 123.10 34.73 1m20s
tendermint 12593597 6.73 267.23 100.10 2m8s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant