-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip: proposed sdk changes #1875
base: dev
Are you sure you want to change the base?
Conversation
SP1 Performance Test Results Branch: chris/sdk-changes-3
|
@@ -12,7 +12,7 @@ The default prover mode generates a list of STARK proofs that in aggregate have | |||
the size of the execution. Use this in settings where you don't care about **verification cost / proof size**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add a section to the docs about the builder pattern.
/// Creates a new network prover builder. See [`NetworkProverBuilder`] for more details. | ||
pub fn builder() -> NetworkProverBuilder { | ||
NetworkProverBuilder::default() | ||
/// Prepare to prove the execution of the given program with the given input in the default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good oppurtunity to think about whether stdin should be &SP1Stdin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it makes sense to consume SP1Stdin, generally you don't need need it anymore afterewards
@@ -328,3 +299,79 @@ where | |||
}) | |||
.await | |||
} | |||
|
|||
/// Builder to prepare and configure proving execution of a program on an input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// A
///
/// B
@@ -22,6 +21,13 @@ impl CudaProver { | |||
let cuda_prover = SP1CudaProver::new(); | |||
Self { prover, cuda_prover: cuda_prover.expect("Failed to initialize CUDA prover") } | |||
} | |||
|
|||
/// Prepare to prove the execution of the given program with the given input in the default |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// A
///
/// B
Motivation
Solution
PR Checklist