Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: proposed sdk changes #1875

Draft
wants to merge 9 commits into
base: dev
Choose a base branch
from
Draft

wip: proposed sdk changes #1875

wants to merge 9 commits into from

Conversation

ctian1
Copy link
Member

@ctian1 ctian1 commented Dec 17, 2024

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

Copy link

github-actions bot commented Dec 18, 2024

SP1 Performance Test Results

Branch: chris/sdk-changes-3
Commit: c7c801b
Author: ctian1

program cycles execute (mHz) core (kHZ) compress (KHz) time success
fibonacci 11291 0.19 2.75 0.46 25s
ssz-withdrawals 2757356 16.83 123.43 34.58 1m20s
tendermint 12593597 6.68 268.68 99.82 2m8s

@@ -12,7 +12,7 @@ The default prover mode generates a list of STARK proofs that in aggregate have
the size of the execution. Use this in settings where you don't care about **verification cost / proof size**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a section to the docs about the builder pattern.

/// Creates a new network prover builder. See [`NetworkProverBuilder`] for more details.
pub fn builder() -> NetworkProverBuilder {
NetworkProverBuilder::default()
/// Prepare to prove the execution of the given program with the given input in the default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good oppurtunity to think about whether stdin should be &SP1Stdin

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to consume SP1Stdin, generally you don't need need it anymore afterewards

@@ -328,3 +299,79 @@ where
})
.await
}

/// Builder to prepare and configure proving execution of a program on an input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// A
///
/// B

@@ -22,6 +21,13 @@ impl CudaProver {
let cuda_prover = SP1CudaProver::new();
Self { prover, cuda_prover: cuda_prover.expect("Failed to initialize CUDA prover") }
}

/// Prepare to prove the execution of the given program with the given input in the default
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/// A
///
/// B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants