Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mdbook docs #191

Merged
merged 14 commits into from
Feb 11, 2024
Merged

feat: mdbook docs #191

merged 14 commits into from
Feb 11, 2024

Conversation

jtguibas
Copy link
Contributor

No description provided.

John Guibas added 2 commits February 10, 2024 18:58
@@ -0,0 +1,143 @@
# Documentation and mdbook related jobs.
# Reference: https://github.com/paradigmxyz/reth/blob/main/.github/workflows/book.yml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change this?

Cargo.toml Outdated
@@ -1,5 +1,5 @@
[workspace]
members = ["core", "cli", "derive", "examples/*", "zkvm"]
members = ["core", "cli", "derive", "examples/*", "zkvm", "program"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait i don't think we can have program in here because of patching

Instead, you should have your script only execute the program with the RISC-V runtime and read `stdout`. Here is an example:

```rust,noplayground
use succinct_core::{SuccinctProver, SuccinctStdin, SuccinctVerifier};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also have this as an example? and import from there?

@jtguibas jtguibas merged commit 1521fa7 into main Feb 11, 2024
2 checks passed
@puma314 puma314 deleted the john/feb10-0257 branch February 14, 2024 07:21
jtguibas added a commit that referenced this pull request Mar 29, 2024
Co-authored-by: John Guibas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants