chore: make FpOperations use PrimeField32 to clean up type inconsistency hacks
#203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
reviewed
Feb 12, 2024
core/src/operations/field/params.rs
Outdated
| @@ -58,7 +56,7 @@ impl<'a, T: Debug + Default + Clone> From<Iter<'a, T>> for Limbs<T> { | |||
| } | |||
|
|
|||
| // TODO: we probably won't need this in the future when we do things properly. | |||
| pub fn convert_polynomial<F: Field>(value: Polynomial<BabyBear>) -> Limbs<F> { | |||
| pub fn convert_polynomial<F: PrimeField32>(value: Polynomial<F>) -> Limbs<F> { | |||
There was a problem hiding this comment.
I think these should be cleaned up since we don't need it anymore?
core/src/operations/field/params.rs
Outdated
| @@ -69,8 +67,7 @@ pub fn convert_polynomial<F: Field>(value: Polynomial<BabyBear>) -> Limbs<F> { | |||
| Limbs(inner) | |||
| } | |||
|
|
|||
| // TODO: we probably won't need this in the future when we do things properly. | |||
| pub fn convert_vec<F: Field>(value: Vec<BabyBear>) -> Vec<F> { | |||
| pub fn convert_vec<F: PrimeField32>(value: Vec<F>) -> Vec<F> { | |||
There was a problem hiding this comment.
same with cleaning this up?
puma314
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it takes
Fieldbut then under the hood, we actually useBabyBear. This PR removes that hack and makesFpOperationstakePrimeField32and use that, hence removing the hardcodedBabyBear.