Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement subscription, add firehose examples #15

Merged
merged 7 commits into from
May 22, 2023

Conversation

sugyan
Copy link
Owner

@sugyan sugyan commented May 16, 2023

resolves #11

Untitled.mov

@benwis
Copy link

benwis commented May 20, 2023

Nice work! Are you decoding embeds as well?

@sugyan
Copy link
Owner Author

sugyan commented May 21, 2023

@benwis I've experimented and it seems that the images embed failed to deserialize. I don't know the details, but perhaps I need to implement the deserialization of blobs correctly...
For now, I'd like to leave this problem as a separate issue and finish the work on this branch as a firehose implementation for extracting text.

@benwis
Copy link

benwis commented May 21, 2023

@benwis I've experimented and it seems that the images embed failed to deserialize. I don't know the details, but perhaps I need to implement the deserialization of blobs correctly... For now, I'd like to leave this problem as a separate issue and finish the work on this branch as a firehose implementation for extracting text.

The reason I ask is because in Bisky we had this weird issue with ciborium where it would fail to parse the internally tagged enum that represented the Embeds.
enarx/ciborium#71

Also, the Blob type is different for the firehose vs non firehose, if I recall one takes a Link map and the other a Byte string.

Perfectly fine to handle this elsewhere, it works well for me!

@sugyan sugyan marked this pull request as ready for review May 22, 2023 00:32
@sugyan sugyan changed the title Feature subscription, add firehose examples feat: Implement subscription, add firehose examples May 22, 2023
@sugyan sugyan merged commit 461e771 into main May 22, 2023
@github-actions github-actions bot mentioned this pull request May 22, 2023
@sugyan sugyan deleted the feature/subscription branch February 19, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subscribe repos example?
2 participants