Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export JsonTruthy #610

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Conversation

Dosenpfand
Copy link

Or is there a specific reason why this is not done?

@sunng87
Copy link
Owner

sunng87 commented Sep 27, 2023

@Dosenpfand do you have a use-case for JsonTruthy? when implementing your own helper?

@coveralls
Copy link

Coverage Status

coverage: 81.112%. remained the same when pulling 818855e on Dosenpfand:reexport-json-truthy into 825baea on sunng87:master.

@sunng87 sunng87 merged commit ea93c15 into sunng87:master Sep 28, 2023
8 checks passed
@Dosenpfand
Copy link
Author

Dosenpfand commented Oct 22, 2023

@sunng87, thanks for merging this!

@Dosenpfand do you have a use-case for JsonTruthy? when implementing your own helper?

Yes, exactly. I am using dotter which uses handlebars-rust with strict mode enabled.

Even with strict mode enabled it would still useful i my opinion, to have a non-strict version of the and and or helpers available. Would you accept a PR for that? Otherwise, I would try to get it merged into dotter itself.

@Dosenpfand Dosenpfand deleted the reexport-json-truthy branch October 22, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants