Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved number compare between different types #679

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

sunng87
Copy link
Owner

@sunng87 sunng87 commented Oct 7, 2024

Fixes #678

Included a new dependency num-order to compare numbers of different types.

@coveralls
Copy link

Coverage Status

coverage: 82.049% (-0.08%) from 82.124%
when pulling 39fee7c on fix/number-compare
into f7583b9 on master.

@sunng87 sunng87 merged commit f9f88ed into master Oct 13, 2024
9 checks passed
@sunng87 sunng87 deleted the fix/number-compare branch October 13, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comparison functions behave incorrectly for integers larger than 2^53
2 participants