Support for displaying sign-in or sign-up initially #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshukertjr
reviewed
Jul 11, 2024
Co-authored-by: Tyler <[email protected]>
Sure, definitely! |
|
Would you be able to update the variable name on other places that it's used as well? |
dshukertjr
reviewed
Oct 4, 2024
| @@ -109,6 +112,7 @@ class SupaEmailAuth extends StatefulWidget { | |||
| this.metadataFields, | |||
| this.extraMetadata, | |||
| this.localization = const SupaEmailAuthLocalization(), | |||
| this.isSigningIn = true, | |||
There was a problem hiding this comment.
Suggested change
| this.isSigningIn = true, | |
| this.isInitiallySigningIn = true, |
| /// Focus node for email field | ||
| final FocusNode _emailFocusNode = FocusNode(); | ||
|
|
||
| @override | ||
| void initState() { | ||
| super.initState(); | ||
| _isSigningIn = widget.isSigningIn; |
There was a problem hiding this comment.
Suggested change
| _isSigningIn = widget.isSigningIn; | |
| _isInitiallySigningIn = widget.isInitiallySigningIn; |
| @@ -120,21 +124,20 @@ class _SupaEmailAuthState extends State<SupaEmailAuth> { | |||
| final _emailController = TextEditingController(); | |||
| final _passwordController = TextEditingController(); | |||
| late final Map<MetaDataField, TextEditingController> _metadataControllers; | |||
| late bool _isSigningIn; | |||
There was a problem hiding this comment.
Suggested change
| late bool _isSigningIn; | |
| late bool _isInitiallySigningIn; |
|
Closing in favor of #116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature
What is the current behavior?
We always display the login form by default
What is the new behavior?
We added a parameter to control whether sign up for or sign-in form is being displayed initially.
Additional context
From the business perspective, depending on the UX flow, you should be able to present either login or sign-up. For example, a page with CTA "try for free, no credit card required" should redirect to a sign-up form, not a login form that requires one additional unnecessary step from the user.