Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat custom email icons #108

Merged

Conversation

HenryRoutson
Copy link
Contributor

What kind of change does this PR introduce?

Allowing no or custom prefix icons / widgets

What is the current behavior?

Prefix icons are set

What is the new behavior?

Prefix icons can be removed or changed

Additional context

I would have put an issue, but this was almost quicker.
The reason for the pull request is simply that the design i want to create doesn't have icons.

I also made a small simplification with the navigateHome function

Thanks!

@HenryRoutson
Copy link
Contributor Author

This is the sort of design i'm looking to create

login-design-examples

@HenryRoutson
Copy link
Contributor Author

HenryRoutson commented Aug 11, 2024

I've added a minimal dark mode example,
as it more closely matches the supabase react auth ui with this merge.
I think an example for applying themes would be good in general.
https://docs-git-docs-add-next-js-server-component-docs-supabase.vercel.app/docs/guides/auth/auth-helpers/auth-ui

Screenshot 2024-08-11 at 9 31 32 pm

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for such an amazing PR! I love it! It looks very nice!

lib/src/components/supa_email_auth.dart Outdated Show resolved Hide resolved
@dshukertjr
Copy link
Member

Would you be able to update the variable names on the places that they are referenced?

@HenryRoutson
Copy link
Contributor Author

Yep, done

Copy link
Member

@dshukertjr dshukertjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@dshukertjr dshukertjr merged commit 41814b9 into supabase-community:main Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants