Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide minimum google authentication scope #131

Conversation

ndnam198
Copy link

What kind of change does this PR introduce?

  • Fix a bug not be able to authenticate using Google account

What is the current behavior?

  • Google throws Exception about lacking logging in scope due to recent Google authentication update

What is the new behavior?

  • The bare minimum required scope are ['email', 'profile'] for logging in were added, now can authenticate with Google again

@dshukertjr
Copy link
Member

I thought this update was a bug that was introduced by Google and later was removed. Do you have any thing that says the change was intentional and is here for good?

@ndnam198
Copy link
Author

ndnam198 commented Oct 30, 2024

Thanks for reply.

yes, you are right. Previously I have to add these minimum scope values into library code just to pass throught Google authentication in my own project (which also uses this package). As a result, I realize that this package has not used the passed in scopes anywhere. That's why I think it can be good to leverage the variable somehow.
But yes, since Google fixed the issue, minimum could be empty array rather than certain values.
So I think you can reject the PR for now and maybe apply the changes in the future when there are actual needs.

@dshukertjr dshukertjr closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants