Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upload gotrue binary as gz instead of xz #1340

Open
wants to merge 1 commit into
base: release/15.6
Choose a base branch
from

Conversation

kangmingtay
Copy link
Member

@kangmingtay kangmingtay commented Nov 26, 2024

What kind of change does this PR introduce?

  • Upload the gotrue binary as a tar.gz file instead of a tar.xz file
  • When combined with https://github.com/supabase/helper-scripts/pull/917, which improves the download speed since it downloads the binary from the same bucket in the region, we can reap the benefits of faster decompression from gzip at the expense of a slightly larger file size (negligible because the download is fast)
  • Perf comparison between decompressing a gz vs xz file:
$ time tar -xzf auth-v2.164.0-arm64.tar.gz

real	0m0.309s
user	0m0.287s
sys	0m0.057s

$ time tar -xf gotrue-v2.164.0-arm64.tar.xz

real	0m0.655s
user	0m0.617s
sys	0m0.088s

@kangmingtay kangmingtay requested review from a team as code owners November 26, 2024 11:53
@kangmingtay kangmingtay changed the base branch from develop to release/15.6 November 26, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants