Allow user-defined container name

[alexdlukens]

I ran into #24 when using this action inside a matrix. The workflow was attempting to start multiple mongodb containers, causing all but one to error out.

My solution to this was to allow the container name to be input as a configuration option, and using the matrix to differentiate the container names and ports.

Example:

strategy:
  fail-fast: false
  matrix:
    python-version: ["3.10", "3.11", "3.12"]

steps:
  - name: Calculate port
    id: calc
    run: |
      PYTHON_VER_INT=$(echo "${{ matrix.python-version }}" | tr -d '.')
      PORT=$((27000 + PYTHON_VER_INT))
      echo "port=$PORT" >> $GITHUB_OUTPUT

  - name: Setup MongoDB service
    uses: alexdlukens/mongodb-github-action@fa13afeb0a920f19491292b6819a6129c09fb42b
    with:
      mongodb-version: 4.4
      mongodb-port: ${{ steps.calc.outputs.port }}
      container-name: mongodb-${{ matrix.python-version }}

Edit:

Would like to note that this issue occurred when running the workflow locally via act

[marcuspoehls]

@alexdlukens Nice addition! Thank you for your contribution! I appreciate your effort. I'm busy today but will review and sort the merge request tomorrow.

[danyalaytekin]

bump 😬 we would also like to use this fix for act. Thanks both.

[marcuspoehls]

@alexdlukens Hey Alex, do you know why the tests are failing? Maybe we can get the test pipeline to succeed and then merge the changes 🙂

[alexdlukens]

@marcuspoehls I'm not sure why the tests are failing. I will investigate today

[alexdlukens]

@marcuspoehls Looks like a test failed because MongoDB did not initialize in 20 seconds. I didn't update anything that would change this behavior, but I could increase the startup timeout on line 59 in https://github.com/supercharge/mongodb-github-action/blob/main/start-mongodb.sh. Please let me know if this solution is acceptable

[marcuspoehls]

@alexdlukens I found the issue: the replica set didn’t start on a custom port. MongoDB always started on the default port. Here’s the fixing commit 7ff7ec9

[danyalaytekin]

Thanks so much @alexdlukens and @marcuspoehls. Our job passes locally in act now solely by referencing supercharge/mongodb-github-action@67dfa2e. Which almost seemed too easy but I've reconfirmed it did fail with 1.10.0.

[alexdlukens]

@marcuspoehls I am bit confused at why the change in 7ff7ec9 fixed this, as --port doesn't exist on the docker run CLI reference. Is this flag documented somewhere else? Either way, thank you for your help with getting the tests to pass!

Final edit here: I see why this works now. I did not know that args after the image name get passed to the process inside the container. Thanks again!

[marcuspoehls]

@alexdlukens Hey Alex, you’re right: all arguments after the image name are arguments for the process inside the Docker container. Basically pass-through arguments.

@danyalaytekin Hey Danyal, thank you for confirming that the container name feature works 🙂 That’s nice!