#62: add option for specifying image #64
Conversation
|
@marcuspoehls please take a look at reviewing/merging this as I'm keen to pull images from ECR rather than Docker Hub |
|
@Sam-Bate-ITV Hey Sam, thank you for your ping 🙂 I’ll review until tomorrow night |
There was a problem hiding this comment.
@Sam-Bate-ITV Thank you for the pull request. I’ve added minor comments. Please have a look and maybe you find time to adjust the code? I would appreciate your help. Let’s push this feature over the finish line 🙂
.github/workflows/main.yml
Outdated
| @@ -18,4 +18,5 @@ jobs: | |||
| - name: Start MongoDB Server | |||
| uses: ./ | |||
| with: | |||
| mongodb-image: 'public.ecr.aws/docker/library/mongo' | |||
There was a problem hiding this comment.
I would like to avoid adding the mongodb-image configuration to all GitHub Action workflows. It would be good if we add a new workflow file using the ECR registry.
@Sam-Bate-ITV Sam, can you please remove all the added mongodb-image configs from the existing workflow YAML files and add a workflow. The new workflow file should be a copy of the test-single-instance.yml that uses a custom image.
There was a problem hiding this comment.
I've reverted this to use the default from docker hub. Of course this may impact the workflow from completing
README.md
Outdated
| @@ -60,6 +60,8 @@ jobs: | |||
| - name: Start MongoDB | |||
| uses: supercharge/[email protected] | |||
| with: | |||
| # Here we are using an image from Amazon's ECR rather than the default image from Docker Hub | |||
| mongodb-image: 'public.ecr.aws/docker/library/mongo' | |||
There was a problem hiding this comment.
Please make the option to use a custom MongoDB docker image a new section in the README.md. Please create a section like here https://github.com/supercharge/redis-github-action/blob/main/README.md#using-a-custom-redis-image
Co-authored-by: Marcus Pöhls <[email protected]>
Relates to and solves issue #62
Adding a new optional field for
mongodb-imagewhich defaults to the original 'mongo'. This allows users to instead use an alternative image like 'public.ecr.aws/docker/library/mongo', avoiding the rate limits of Docker Hub.Note that in this PR I also set the tests to use the image from Amazon's docker repo so that all the tests can run without hitting rate limit of Docker Hub meaning all the tests ran within a few minutes.