Introduction of formsets in wizards. #6
+287
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Increased coverage * Docs missing - will add them as I introduce it to a project
|
I will try and get to this early next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one is not ready for pulling (docs missing, not yet rolled out in production). All tests pass plus any new functionality is tested ( I even increased coverage :) ).
I 'm sending the pull request because I would like your thoughts on the API changes. Also it only works with a cache session backend (the default session backend cannot pickle formsets).
So please if you find the time provide some feedback on the changes so I can work on them while I prepare the docs and I test it in a production environment.
Thanks,
Yorgos