Skip to content

Commit

Permalink
Release V4.0.0
Browse files Browse the repository at this point in the history
- *[NEW]* - add MySQL support for bans ([#8](#8)) (Thank you very much [@tobias-2006](https://github.com/Tobias-2006))
- *[NEW]* - `/baninfo`: Added a new message, when the player isn't banned ([#17](#17))
- *[FIX]* - added missing permissions
- *[VERSION]* - Version bump
  • Loading branch information
supercrafter333 committed Sep 7, 2021
1 parent 4ae1369 commit 53c226b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .changelogs.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
- fixed missing permissions for forms and commands
- Version bump

### Changelog V3.0.0 » V4.0.0-DEV
### Changelog V3.0.0 » V4.0.0
> This version does contain many major code changes from the previous version. This version is a bug-fix and feature update.
- *[NEW]* - add MySQL support for bans ([#8](https://github.com/supercrafter333/BetterBan/issues/8)) (Thank you very much [@Tobias-2006](https://github.com/Tobias-2006))
- *[NEW]* - `/baninfo`: Added a new message, when the player isn't banned ([#17](https://github.com/supercrafter333/BetterBan/issues/17))
Expand Down
2 changes: 1 addition & 1 deletion plugin.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: BetterBan
version: 3.0.0
version: 4.0.0
api: 3.0.0
main: supercrafter333\BetterBan\BetterBan
author: supercrfafter333
Expand Down
2 changes: 1 addition & 1 deletion src/supercrafter333/BetterBan/BetterBan.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class BetterBan extends PluginBase
/**
* Version of BetterBan
*/
public const VERSION = "4.0.0-DEV";
public const VERSION = "4.0.0";

/**
* @var null
Expand Down

1 comment on commit 53c226b

@Ifera
Copy link

@Ifera Ifera commented on 53c226b Sep 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @supercrafter333,

I regret to inform you that your plugin "BetterBan" (v4.0.0 submitted on 2021-09-07T18:29:01.000Z) has been rejected.

B6 — Do not block the main thread:

Except during startup/shutdown, plugins must avoid blocking the main thread with operations that cause the thread to wait for a signal. Apart from small-scale local file IO operations (compare with the extent used in PocketMine internals), no blocking operations (e.g. curl calls, MySQL queries, heavy SQLite calls, O(players) scanning) are allowed to be executed on the main thread, or to have the main thread wait for such operations.

Please resolve these issues and submit the plugin again.

This comment is posted here because this is the last commit when the released build was created.

Please sign in to comment.