Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SW-1263] Remove languages from store #2348

Merged
merged 1 commit into from
Oct 5, 2023
Merged

[SW-1263] Remove languages from store #2348

merged 1 commit into from
Oct 5, 2023

Conversation

pstachel
Copy link
Contributor

No description provided.

@pstachel pstachel force-pushed the feat/remove-languages-from-store branch from 5ea9e8b to bad366d Compare September 19, 2023 08:56
@github-actions
Copy link

Deployed to feat-remove-languages-from-store.wallet.z52da5wt.xyz, artifacts

CedrikNikita
CedrikNikita requested changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@CedrikNikita CedrikNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Language being preserved

@pstachel pstachel force-pushed the feat/remove-languages-from-store branch from bad366d to d3a5630 Compare September 21, 2023 11:37
CedrikNikita
CedrikNikita reviewed Sep 22, 2023
View reviewed changes
src/popup/App.vue Outdated Show resolved Hide resolved
peronczyk
peronczyk requested changes Sep 25, 2023
View reviewed changes
src/composables/languages.ts Outdated Show resolved Hide resolved
src/composables/languages.ts Outdated Show resolved Hide resolved
src/lib/i18n.ts Outdated Show resolved Hide resolved
src/popup/App.vue Outdated Show resolved Hide resolved
src/popup/App.vue Outdated Show resolved Hide resolved
src/popup/pages/LanguageSettings.vue Outdated Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
@pstachel pstachel force-pushed the feat/remove-languages-from-store branch 2 times, most recently from 0f1ab6a to cc85d97 Compare September 25, 2023 13:41
@pstachel pstachel changed the base branch from develop to refactor/move-account-vuex-state-to-composable September 27, 2023 11:36
@pstachel pstachel force-pushed the feat/remove-languages-from-store branch from cc85d97 to ef50d19 Compare September 27, 2023 11:38
@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from 66985da to 51c7e86 Compare September 27, 2023 12:23
@pstachel pstachel force-pushed the feat/remove-languages-from-store branch 2 times, most recently from c95c66d to 5d8c156 Compare September 27, 2023 13:20
@pstachel pstachel force-pushed the feat/remove-languages-from-store branch from 5d8c156 to ff83c61 Compare October 2, 2023 14:30
CedrikNikita
CedrikNikita approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@CedrikNikita CedrikNikita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look reasonable.

@Liubov-crypto
Copy link
Collaborator

cus

@peronczyk peronczyk force-pushed the refactor/move-account-vuex-state-to-composable branch from fc1088e to e255040 Compare October 4, 2023 07:16
Base automatically changed from refactor/move-account-vuex-state-to-composable to develop October 4, 2023 11:02
@pstachel pstachel force-pushed the feat/remove-languages-from-store branch from ff83c61 to fcaa698 Compare October 4, 2023 11:53
@pstachel pstachel force-pushed the feat/remove-languages-from-store branch from fcaa698 to 2988015 Compare October 4, 2023 14:19
@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented Oct 5, 2023 •
edited
Loading

feat-remove-languages-from-store.wallet.z52da5wt.xyz

Reproducible on develop too, will create a separate issue.
The rest LGTM

@peronczyk peronczyk merged commit 21b48c3 into develop Oct 5, 2023
4 checks passed
@peronczyk peronczyk deleted the feat/remove-languages-from-store branch October 5, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradodo konradodo konradodo left review comments

@CedrikNikita CedrikNikita CedrikNikita approved these changes

@peronczyk peronczyk peronczyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pstachel @Liubov-crypto @peronczyk @CedrikNikita @konradodo