Fix: reporting IME geometry crashes when is true in SuperEditor, care…

…t doesn't blink when placed by 'autofocus' in SuperEditor (Resolves #1566) (#1575)
superlistapp · Oct 28, 2023 · 6e2040f · 6e2040f
1 parent e63d479
commit 6e2040f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/super_editor/lib/src/default_editor/document_gestures_touch_ios.dart b/super_editor/lib/src/default_editor/document_gestures_touch_ios.dart
@@ -129,7 +129,7 @@ class SuperEditorIosControlsController {
 
   /// Whether the caret (collapsed handle) should blink right now.
   ValueListenable<bool> get shouldCaretBlink => _shouldCaretBlink;
-  final _shouldCaretBlink = ValueNotifier<bool>(false);
+  final _shouldCaretBlink = ValueNotifier<bool>(true);
 
   /// Tells the caret to blink by setting [shouldCaretBlink] to `true`.
   void blinkCaret() => _shouldCaretBlink.value = true;

diff --git a/super_editor/lib/src/default_editor/document_ime/supereditor_ime_interactor.dart b/super_editor/lib/src/default_editor/document_ime/supereditor_ime_interactor.dart
@@ -293,9 +293,12 @@ class SuperEditorImeInteractorState extends State<SuperEditorImeInteractor> impl
       return;
     }
 
-    _reportSizeAndTransformToIme();
-    _reportCaretRectToIme();
-    _reportTextStyleToIme();
+    final myRenderBox = context.findRenderObject() as RenderBox?;
+    if (myRenderBox != null && myRenderBox.hasSize) {
+      _reportSizeAndTransformToIme();
+      _reportCaretRectToIme();
+      _reportTextStyleToIme();
+    }
 
     // There are some operations that might affect our transform, size and the caret rect,
     // but we can't react to them.

diff --git a/super_editor/lib/src/default_editor/super_editor.dart b/super_editor/lib/src/default_editor/super_editor.dart
@@ -554,7 +554,8 @@ class SuperEditorState extends State<SuperEditor> {
             editor: widget.editor,
             document: widget.document,
             selection: _composer.selectionNotifier,
-            isDocumentLayoutAvailable: () => _docLayoutKey.currentContext != null,
+            isDocumentLayoutAvailable: () =>
+                (_docLayoutKey.currentContext?.findRenderObject() as RenderBox?)?.hasSize == true,
             getDocumentLayout: () => editContext.documentLayout,
             placeCaretAtEndOfDocumentOnGainFocus: widget.selectionPolicies.placeCaretAtEndOfDocumentOnGainFocus,
             restorePreviousSelectionOnGainFocus: widget.selectionPolicies.restorePreviousSelectionOnGainFocus,