-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.jinja #2407
Update index.jinja #2407
Conversation
Fix text to copy
Fixes a broken link.
doc/website/source/index.jinja
Outdated
@@ -213,8 +213,8 @@ layout: | |||
|
|||
<script> | |||
function copyActivationToClipboard() { | |||
navigator.clipboard.writeText("dart pub global activate static_shock_cli"); | |||
navigator.clipboard.writeText("super_editor: ^0.2.7"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be injectable. Can you locate the code that shows the value in the header? The value should be coming from the GitHub plugin, and injected through a Jinja variable. You should be able to use that same injection here for "^0.2.7".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the version number should be injected now as per my latest commit.
Use the same jinja injection code as the display text above. Both should now show the same version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks!
@suragch - Whenever we merge something into |
@matthew-carroll The |
Ok, I guess I never cherry picked the original docs. In that case, don't worry about cherry picking in this case. |
Fix text to copy when the button is pressed. It should copy the shown text. An even better solution would be to make a single source of truth for both the shown text and the copied text.
This PR also fixes a broken link to the SuperEditor Quickstart guides.