Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.jinja #2407

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Update index.jinja #2407

merged 4 commits into from
Nov 19, 2024

Conversation

suragch
Copy link
Contributor

@suragch suragch commented Nov 15, 2024

Fix text to copy when the button is pressed. It should copy the shown text. An even better solution would be to make a single source of truth for both the shown text and the copied text.

This PR also fixes a broken link to the SuperEditor Quickstart guides.

Fix text to copy
@@ -213,8 +213,8 @@ layout:

<script>
function copyActivationToClipboard() {
navigator.clipboard.writeText("dart pub global activate static_shock_cli");
navigator.clipboard.writeText("super_editor: ^0.2.7");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be injectable. Can you locate the code that shows the value in the header? The value should be coming from the GitHub plugin, and injected through a Jinja variable. You should be able to use that same injection here for "^0.2.7".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the version number should be injected now as per my latest commit.

Use the same jinja injection code as the display text above. Both should now show the same version number.
Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks!

@matthew-carroll matthew-carroll merged commit 69b06e1 into superlistapp:main Nov 19, 2024
12 of 14 checks passed
@matthew-carroll
Copy link
Contributor

@suragch - Whenever we merge something into main we also need to cherry pick that into stable. Can you put up a PR pointing at stable that includes a cherry pick of this commit from main?

@suragch
Copy link
Contributor Author

suragch commented Nov 20, 2024

@matthew-carroll The stable branch doesn't have doc/website/source/index.jinja at all, so I'm getting a conflict with the cherry pick. What is the difference between main and stable here?

@matthew-carroll
Copy link
Contributor

Ok, I guess I never cherry picked the original docs. In that case, don't worry about cherry picking in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants