-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TaskNode
s Checkbox
visual density to depend on the ThemeData.visualDensity
#2444
Update TaskNode
s Checkbox
visual density to depend on the ThemeData.visualDensity
#2444
Conversation
…ata.visualDensity`
@TahaTesser which tests are failing without this modification? |
This is the test super_editor/super_editor/test/super_editor/supereditor_input_keyboard_actions_test.dart Lines 1262 to 1275 in 90f4fe0
Here is a minimal sample to reproduce the behavior. expand to view the code sampleimport 'package:flutter/material.dart';
import 'package:super_editor/super_editor.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
final composer = MutableDocumentComposer();
final editor = createDefaultDocumentEditor(
document: MutableDocument(
nodes: [
TaskNode(
id: '1',
text: AttributedText('This is a task'),
isComplete: false),
ListItemNode.unordered(
id: '2', text: AttributedText('This is a list item')),
],
),
composer: composer);
return MaterialApp(
home: Scaffold(
body: SuperEditor(
editor: editor,
componentBuilders: [
TaskComponentBuilder(editor),
...defaultComponentBuilders,
],
),
),
);
}
}
With flutter/flutter#159081With flutter/flutter#159081 and this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks.
@angelosilvestre can you cherry pick this? |
…nd on the `ThemeData.visualDensity` (#2444)
…nd on the `ThemeData.visualDensity` (#2444)
FYI, I'm updating flutter/tests super_editor registry to unblock Flutter PR, flutter/flutter#159081. See flutter/tests#437. I chose the latest |
We're updating
Checkbox
default visual density to not depend onThemeData.visualDensity
and default toVisualDensity.standard
in order to match Material Design 3 specifications in flutter/flutter#159081.This could produce visual changes for the users, however, if the users don't want to follow M3 compliance then they can override the
Checkbox.visualDensity
to depend onThemeData.visualDensity
.This PR makes such override to pass customer testing suite in the Flutter PR as
super_editor
is part of this suite.