Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuperEditor] Add ClearDocumentRequest (Resolves #2360) #2460

Merged
merged 2 commits into from
Dec 20, 2024
Merged

[SuperEditor] Add ClearDocumentRequest (Resolves #2360) #2460

merged 2 commits into from
Dec 20, 2024

Conversation

angelosilvestre
Copy link
Collaborator

[SuperEditor] Add ClearDocumentRequest. Resolves #2360

Clearing a document involves:

  • Removing all the nodes
  • Adding a new empty paragraph
  • Placing the caret at the newly created paragraph
  • Clearing the composing region

This PR adds a ClearDocumentRequest, which packs all of those actions in a single request.

matthew-carroll
matthew-carroll approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@matthew-carroll matthew-carroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthew-carroll matthew-carroll merged commit a5857c5 into main Dec 20, 2024
10 of 14 checks passed
@matthew-carroll matthew-carroll deleted the 2360_clear_document_request branch December 20, 2024 01:27
github-actions bot pushed a commit that referenced this pull request Dec 20, 2024
@angelosilvestre @web-flow
[SuperEditor] Add ClearDocumentRequest (Resolves #2360) (#2460)
1a77a36
@github-actions github-actions bot mentioned this pull request Dec 20, 2024
Merged
matthew-carroll pushed a commit that referenced this pull request Dec 20, 2024
@angelosilvestre @matthew-carroll
[SuperEditor] Add ClearDocumentRequest (Resolves #2360) (#2460)
4f9e807
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthew-carroll matthew-carroll matthew-carroll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SuperEditor] - Create a clearDocumentRequest
2 participants
@angelosilvestre @matthew-carroll