Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed eslint-plugin-prettier and eslint-config-prettier #579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattpocock
Copy link
Contributor

@mattpocock mattpocock commented Sep 6, 2024

Cherrypicked from #574

Copy link

changeset-bot bot commented Sep 6, 2024

⚠️ No Changeset found

Latest commit: bd3271d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@macksal macksal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems useful. I agree that separate linting and formatting is a good goal. I wasn't aware that most shareable configs don't enable styling rules anymore, making eslint-config-prettier redundant.

@mattpocock mattpocock mentioned this pull request Sep 6, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants