fix: session refresh loop if expired token is passed in headers #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anku255
force-pushed
the
fix/session-refresh-loop
branch
from
64ca8f4 to
967cb8b
Compare
anku255
changed the title
rishabhpoddar
suggested changes
Jun 14, 2024
| return false; | ||
| } | ||
|
|
||
|
|
||
| String accessToken = Utils.getTokenForHeaderAuth(Utils.TokenType.ACCESS, applicationContext); | ||
| String refreshToken = Utils.getTokenForHeaderAuth(Utils.TokenType.REFRESH, applicationContext); | ||
| if (accessToken != null && refreshToken != null && value.equals("Bearer " + accessToken)) { |
There was a problem hiding this comment.
we should check with ignore case?
| @@ -46,18 +49,20 @@ private Request removeAuthHeaderIfMatchesLocalToken(Request request, Request.Bui | |||
| String refreshToken = Utils.getTokenForHeaderAuth(Utils.TokenType.REFRESH, context); | |||
|
|
|||
| if (accessToken != null && refreshToken != null && originalHeader.equals("Bearer " + accessToken)) { | |||
There was a problem hiding this comment.
shuold use ignore case?
testHelpers/testapp/app/src/test/java/com/example/example/SuperTokensHttpURLConnectionTest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
Fixes #72
Related issues
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)
Documentation changes
(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)
Checklist for important updates
frontendDriverInterfaceSupported.jsonfile has been updated (if needed)app/src/main/java/com/supertokens/session/Version.javaapp/build.gradlegit tag) in the formatvX.Y.Z, and then find the latest branch (git branch --all) whoseX.Yis greater than the latest released tag.