Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Updates docker-entrypoint.sh file #15

Closed
wants to merge 1 commit into from
Closed

🔧 Updates docker-entrypoint.sh file #15

wants to merge 1 commit into from

Conversation

charlawl
Copy link

Overview

Changing the docker-entrypoint.sh script to remove references to chown command as this causes the container in heroku to crash at runtime. This is outlined in an issue with the mySql docker setup for supertokens supertokens/supertokens-core#354.

We're also going with forking the repository as this issue prevents us from running the image directly on heroku and we want to be able to pin our version of supertokens core to avoid unstable releases and breaking changes

@charlawl charlawl changed the title Updating docker-entrypoint.sh file 🔧 Updates docker-entrypoint.sh file Jan 23, 2023
@charlawl charlawl closed this Jan 23, 2023
@rishabhpoddar
Copy link
Contributor

hey @charlawl why did you close this issue? Do you need any help?

@monotek
Copy link

monotek commented May 3, 2023

Imho the chown from the entrypoint should be removed or at least be optional.

Changing stuff in the container on runtime is bad practice as the container should be imutable.

If the container is run with readonly filesystem chown will fail all the time.

@rishabhpoddar
Copy link
Contributor

I agree @monotek - please feel free to make a PR for this fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants