pr fixes

supertokens · Nov 12, 2024 · 3bb7234 · 3bb7234
1 parent 3649b45
commit 3bb7234
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/lib/ts/recipe/webauthn/api/implementation.ts b/lib/ts/recipe/webauthn/api/implementation.ts
@@ -1050,7 +1050,6 @@ export default function getAPIImplementation(): APIInterface {
                         userContext,
                     });
 
-                    // todo decide how to handle these
                     if (
                         createUserResponse.status === "INVALID_CREDENTIALS_ERROR" ||
                         createUserResponse.status === "GENERATED_OPTIONS_NOT_FOUND_ERROR" ||

diff --git a/lib/ts/recipe/webauthn/recipe.ts b/lib/ts/recipe/webauthn/recipe.ts
@@ -97,7 +97,6 @@ export default class Recipe extends RecipeModule {
                 ? new EmailDeliveryIngredient(this.config.getEmailDeliveryConfig(this.isInServerlessEnv))
                 : ingredients.emailDelivery;
 
-        // todo check correctness
         PostSuperTokensInitCallbacks.addPostInitCallback(() => {
             const mfaInstance = MultiFactorAuthRecipe.getInstance();
             if (mfaInstance !== undefined) {

diff --git a/lib/ts/recipe/webauthn/recipeImplementation.ts b/lib/ts/recipe/webauthn/recipeImplementation.ts
@@ -33,8 +33,7 @@ export default function getRecipeInterface(
             if (emailInput !== undefined) {
                 email = emailInput;
             } else if (recoverAccountTokenInput !== undefined) {
-                // todo check if should decode using Core or using sdk; atm decided on usinng the sdk so to not make another roundtrip to the server
-                // the actual verification of the token will be done during consumeRecoverAccountToken
+                // the actual validation of the token will be done during consumeRecoverAccountToken
                 let decoded: jose.JWTPayload | undefined;
                 try {
                     decoded = await jose.decodeJwt(recoverAccountTokenInput);