Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved edge function compatibility #702

Merged
merged 30 commits into from
Oct 10, 2023

Conversation

porcellus
Copy link
Collaborator

Summary of change

feat: use built-in fetch when available

Related issues

  • Reported on discord

Test Plan

  • Existing tests cover normal functionality
  • Vercel test deploy (in progress)

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.

@porcellus porcellus force-pushed the feat/edge_function_compatibility branch 2 times, most recently from 1e2a7f4 to 9bdb66d Compare September 28, 2023 14:27
@porcellus porcellus force-pushed the feat/edge_function_compatibility branch from 9bdb66d to 5aad4fe Compare September 28, 2023 15:53
* feat: add netlify.toml to next example

* docs(examples): add postinstall script to install root deps in CI deploys

* docs(examples): update appinfo to point to the netlify deployment if defined

* docs(examples): update appinfo to point to the netlify deployment

* docs(examples): update appinfo to point to the netlify deployment

* test: update example tests

* chore: prettier

* test: add edge function test

* test: make sure the nextjs test call refresh to check edge compatibility
@porcellus porcellus changed the base branch from 16.0 to 16.2 October 3, 2023 08:43
lib/ts/framework/custom/framework.ts Show resolved Hide resolved
@@ -0,0 +1,5 @@
#!/bin/bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add to .npmignore.

@rishabhpoddar rishabhpoddar changed the base branch from 16.2 to 16.3 October 10, 2023 14:13
@rishabhpoddar rishabhpoddar merged commit 367d41b into 16.3 Oct 10, 2023
13 of 14 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/edge_function_compatibility branch October 10, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants