Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: user management support API types #944

Draft
wants to merge 12 commits into
base: 21.0
Choose a base branch
from

Conversation

deepjyoti30-st
Copy link
Contributor

Summary of change

This PR defines the types for API interface for user management related functionality.

Related issues

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2024

Deploying supertokens-node-pr-check-for-edge-function-compat with  Cloudflare Pages  Cloudflare Pages

Latest commit: ed648ed
Status: ✅  Deploy successful!
Preview URL: https://3f0a1ab0.supertokens-node-b95.pages.dev

View logs

lib/ts/recipe/emailpassword/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/emailpassword/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/emailpassword/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/emailpassword/types.ts Outdated Show resolved Hide resolved
@@ -325,6 +325,40 @@ export type APIInterface = {
}
| GeneralErrorResponse
>);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try out (emailverification in required mode, and account linking switched on):

  • First factor is passwordless -> login with email A, then call the signUpPOST API with email A and some password and the access token of the session. See what happens.
  • First factor is passwordless -> login with email A, mark email A as unverified, then call the signUpPOST API with email A and some password and the access token of the session. See what happens.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API can be called when setting a password for an existing account that has no email password login method.

lib/ts/recipe/multifactorauth/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/multifactorauth/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/multifactorauth/types.ts Outdated Show resolved Hide resolved
lib/ts/recipe/multifactorauth/types.ts Outdated Show resolved Hide resolved
newPassword: string;
oldPassword?: string;
};
session: SessionContainerInterface;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

session verification here should not have overrideGlobalClaimValidators: () => [] in our api implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants