Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate MFA claim before allowing TOTP device removal #963

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

porcellus
Copy link
Collaborator

Summary of change

(A few sentences about this PR)

Related issues

  • Link to issue1 here
  • Link to issue1 here

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • If new thirdparty provider is added,
    • update switch statement in recipe/thirdparty/providers/configUtils.ts file, createProvider function.
    • add an icon on the user management dashboard.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the add-ts-no-check.js file to include that
  • If added a new recipe / api interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If added a new recipe, then make sure to expose it inside the recipe folder present in the root of this repo. We also need to expose its types.
  • If added a new entry point, then make sure that it is importable by adding it to the exports in package.json

Remaining TODOs for this PR

  • Item1
  • Item2

@porcellus porcellus force-pushed the backport20/properly_check_claims_in_removeDevice branch from 7797099 to 28d90c3 Compare November 22, 2024 13:10
Copy link

cloudflare-workers-and-pages bot commented Nov 22, 2024

Deploying supertokens-node-pr-check-for-edge-function-compat with  Cloudflare Pages  Cloudflare Pages

Latest commit: 23776d1
Status: ✅  Deploy successful!
Preview URL: https://5adcf510.supertokens-node-b95.pages.dev

View logs

@porcellus porcellus merged commit 69c29e3 into 20.1 Nov 26, 2024
17 of 18 checks passed
@porcellus porcellus deleted the backport20/properly_check_claims_in_removeDevice branch November 26, 2024 15:07
porcellus added a commit that referenced this pull request Nov 26, 2024
* fix: validate MFA claim before allowing TOTP device removal

* fix: fix how we check the MFA claim in removeDevice
porcellus added a commit that referenced this pull request Nov 28, 2024
* fix: validate MFA claim before allowing TOTP device removal

* fix: fix how we check the MFA claim in removeDevice
porcellus added a commit that referenced this pull request Nov 28, 2024
* fix: validate MFA claim before allowing TOTP device removal

* fix: fix how we check the MFA claim in removeDevice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant