fix: axios error transformation on network errors (#126)

* fix: axios error transformation on network errors #5644

* refactor: rename variables for clarity

CHANGELOG.md

@@ -6,6 +6,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [unreleased]
 
+## [5.1.1] - 2024-06-12
+
+### Fixes
+
+- Fixed an issue in the Axios interceptor that caused it to throw when encountering a network error
+
 ## [5.1.0] - 2024-06-04
 
 ### Changes

TestingApp/test/axios2.spec.js

@@ -298,6 +298,63 @@ describe("Axios AuthHttpRequest class tests", function() {
         assert(idRefreshInCookies.length === 0);
     });
 
+    it("should throw error if refresh fails with a network error", async function() {
+        await startST();
+        AuthHttpRequest.addAxiosInterceptors(axiosInstance);
+        const origFetch = global.fetch;
+        global.fetch = async (...input) => {
+            try {
+                if (input[0].endsWith("/auth/session/refresh")) {
+                    input[0] = "http://localhost:1234/nope";
+                }
+                return await origFetch(...input);
+            } catch (err) {
+                throw err;
+            }
+        };
+        AuthHttpRequest.init({
+            apiDomain: BASE_URL,
+            tokenTransferMethod: "cookie"
+        });
+
+        let userId = "testing-supertokens-react-native";
+
+        let loginResponse = await axiosInstance.post(`${BASE_URL}/login`, JSON.stringify({ userId }), {
+            headers: {
+                Accept: "application/json",
+                "Content-Type": "application/json"
+            }
+        });
+        let userIdFromResponse = loginResponse.data;
+        assertEqual(userId, userIdFromResponse);
+
+        cookieJar.setCookieSync("sIdRefreshToken=asdf", `${BASE_URL}/`);
+
+        // This is to verify that the cookie is correctly set
+        let currentCookies = cookieJar.getCookiesSync(`${BASE_URL}/`);
+        let idRefreshInCookies = currentCookies.filter(i => i.key === "sIdRefreshToken");
+        let accessTokenInCookies = currentCookies.filter(i => i.key === "sAccessToken");
+
+        assert(idRefreshInCookies.length !== 0);
+        assert(accessTokenInCookies.length !== 0);
+
+        //check that the number of times the refreshAPI was called is 0
+        assert((await getNumberOfTimesRefreshCalled()) === 0);
+
+        try {
+            await axiosInstance("http://localhost:1234/asdf");
+            await axiosInstance({
+                url: `${BASE_URL}/`,
+                method: "GET",
+                headers: { "Cache-Control": "no-cache, private" }
+            });
+        } catch (err) {
+            assert(err.isAxiosError);
+            assert.strictEqual(err.code, "ECONNREFUSED");
+            assert.strictEqual(err.response, undefined);
+        }
+    });
+
     it("test that interception happens based on the return value of shouldDoInterceptionBasedOnUrl override", async function() {
         await startST();
         AuthHttpRequest.addAxiosInterceptors(axiosInstance);

lib/ts/axiosError.ts

@@ -62,37 +62,43 @@ function enhanceAxiosError(
     return error;
 }
 
-export async function createAxiosErrorFromFetchResp(response: Response): Promise<AxiosError> {
+export async function createAxiosErrorFromFetchResp(responseOrError: Response): Promise<AxiosError> {
     const config = {
-        url: response.url,
-        headers: response.headers
+        url: responseOrError.url,
+        headers: responseOrError.headers
     };
-    const contentType = response.headers.get("content-type");
-    let data;
-    if (!contentType || contentType.includes("application/json")) {
-        try {
-            data = await response.json();
-        } catch {
-            data = await response.text();
+    const isResponse = "status" in responseOrError;
+    let axiosResponse;
+    if (isResponse) {
+        let data;
+        const contentType = responseOrError.headers.get("content-type");
+        if (!contentType || contentType.includes("application/json")) {
+            try {
+                data = await responseOrError.json();
+            } catch {
+                data = await responseOrError.text();
+            }
+        } else if (contentType.includes("text/")) {
+            data = await responseOrError.text();
+        } else {
+            data = await responseOrError.blob();
         }
-    } else if (contentType.includes("text/")) {
-        data = await response.text();
-    } else {
-        data = await response.blob();
-    }
 
-    const axiosResponse = {
-        data,
-        status: response.status,
-        statusText: response.statusText,
-        headers: response.headers,
-        config: config,
-        request: undefined
-    };
+        axiosResponse = {
+            data,
+            status: responseOrError.status,
+            statusText: responseOrError.statusText,
+            headers: responseOrError.headers,
+            config: config,
+            request: undefined
+        };
+    }
     return enhanceAxiosError(
-        new Error("Request failed with status code " + response.status),
+        "status" in responseOrError
+            ? new Error("Request failed with status code " + responseOrError.status)
+            : responseOrError,
         config,
-        undefined,
+        (responseOrError as any).code,
         undefined,
         axiosResponse
     );

lib/ts/version.ts

@@ -12,6 +12,6 @@
  * License for the specific language governing permissions and limitations
  * under the License.
  */
-export const package_version = "5.1.0";
+export const package_version = "5.1.1";
 
 export const supported_fdi = ["1.16", "1.17", "1.18", "1.19", "2.0", "3.0"];

package.json

@@ -1,6 +1,6 @@
 {
   "name": "supertokens-react-native",
-  "version": "5.1.0",
+  "version": "5.1.1",
   "description": "React Native SDK for SuperTokens",
   "main": "index.js",
   "scripts": {