Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make mocha always exit when all tests ran in CI #237

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

porcellus
Copy link
Collaborator

Summary of change

test: make mocha always exit when all tests ran in CI

Related issues

Test Plan

N/A

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

@github-actions
Copy link

size-limit report 📦

Path Size
lib/build/bundleEntry.js 19.21 KB (0%)

@rishabhpoddar rishabhpoddar merged commit b963fd3 into 17.0 Sep 24, 2023
3 of 4 checks passed
@rishabhpoddar rishabhpoddar deleted the ci/exit_on_tests_done branch September 24, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants