Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update typos in debug logs #239

Merged
merged 2 commits into from
Jan 3, 2024
Merged

fix: Update typos in debug logs #239

merged 2 commits into from
Jan 3, 2024

Conversation

prateek3255
Copy link
Contributor

@prateek3255 prateek3255 commented Jan 3, 2024

Summary of change

  • Fix typos in debug logs
  • Move debug logging enabler outside validateAndNormaliseInputOrThrowError

Related issues

N/A

Test Plan

N/A

Documentation changes

N/A

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/ts/version.ts
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs for this PR

N/A

@prateek3255 prateek3255 changed the base branch from master to 17.0 January 3, 2024 12:20
Copy link

github-actions bot commented Jan 3, 2024

size-limit report 📦

Path Size
lib/build/bundleEntry.js 19.21 KB (-0.07% 🔽)

@prateek3255 prateek3255 marked this pull request as ready for review January 3, 2024 12:26
@rishabhpoddar rishabhpoddar merged commit 144f033 into 17.0 Jan 3, 2024
10 checks passed
@rishabhpoddar rishabhpoddar deleted the fix-logging branch January 3, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants