Skip to content

Commit

Permalink
rust/Cargo.toml: work around the compilation problem with clang++.
Browse files Browse the repository at this point in the history 
This doesn't actually guarantee that the problem is resolved in
dependent package, because the latter can override the version.
  • Loading branch information
@dot-asm
dot-asm committed Nov 5, 2024
1 parent 73c8a45 commit ba732d8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rust/Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ include = [
[dependencies]

[build-dependencies]
cc = "^1.0.70"
cc = "^1.0.70, <1.1.32"

This comment has been minimized.

Sign in to view

Copy link
@nazar-pc

nazar-pc Nov 24, 2024

This is not a great solution. Downstream users can force any version above 1.0.70 themselves if needed, but this way you prevent them from ever upgrading above 1.1.32 even if the issue was fixed upstream. Please don't do this, it causes more issues than fixes long-term.

This comment has been minimized.

Sign in to view

Copy link
@nazar-pc

nazar-pc Nov 30, 2024

Also please leave a TODO pointing to the issue describing the compilation problem, such that it is clear when this workaround can be removed. And no, in contrast to the commit message when dependency is forced to be below certain version it is NOT possible to override it, you enforce this limit on every project project downstream.
which = "^4.0"

[features]
Expand Down

0 comments on commit ba732d8

Please sign in to comment.