-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compatibility with LV v0.20 #725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
msaraiva
commented
Jan 3, 2024
- Fix Malformed HTML in rendered.js
- Fix error when passing special chars as literals inside an expression
tiagoefmoraes
approved these changes
Jan 4, 2024
I have run into some other issues that are not fixed with this branch related to LiveComponents, I made a comment about it here: #713 |
Ignore my previous comment, this branch is OK on liveview Users do need to be careful, and make sure all For example:In previous versions the following works OK, (but maybe poorly optimized?):defmodule StaticComponent do
@moduledoc "Static component used by a livecomponent"
use Surface.Component
slot default
def render(assigns) do
~F"""
<div>
<#slot />
</div>
"""
end
end
defmodule ALiveComponent do
@moduledoc "live component with static component at root"
use Surface.LiveComponent
def render(assigns) do
~F"""
<StaticComponent>
<div>
Some LiveComponent Content
</div>
</StaticComponent>
"""
end
end
defmodule ALiveView do
@moduledoc "LiveView that renders the livecomponent"
use Surface.LiveView
def render(assigns) do
~F"""
<ALiveComponent id="a_live_component" />
"""
end
end This PR requires the following change to the above example live component (additional wrapping static node):defmodule ALiveComponent do
@moduledoc "additional static html node at root of live component"
use Surface.LiveComponent
def render(assigns) do
~F"""
<div>
<StaticComponent>
<div>
Some LiveComponent Content
</div>
</StaticComponent>
</div>
"""
end
end |
msaraiva
force-pushed
the
fix-lv-20-compat
branch
from
February 6, 2024 17:43
6f3f172
to
b7cf846
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.